Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(font-display): handle carriage returns #7712

Merged
merged 1 commit into from
Mar 26, 2019
Merged

core(font-display): handle carriage returns #7712

merged 1 commit into from
Mar 26, 2019

Conversation

patrickhulce
Copy link
Collaborator

Summary
Apparently leftover \r characters destroy our match statement later on so we should remove them before trying to find our @font-face declarations.

Related Issues/PRs
#7708

@patrickhulce patrickhulce mentioned this pull request Mar 26, 2019
Closed
wardpeet
wardpeet approved these changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks seems legit!

@paulirish paulirish merged commit 77d1656 into master Mar 26, 2019
@paulirish paulirish deleted the fix_font_display_carriage_return branch March 26, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhulce @wardpeet @paulirish