Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(main-thread-tasks): handle last task not finishing #7728

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Mar 27, 2019

Summary
Treats 'B' events without a corresponding 'E' as if they ended at the time of trace end.

Related Issues/PRs
#7691

@connorjclark
Copy link
Collaborator

Looks good. I'll verify in Canary now.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lighthouse-core/computed/main-thread-tasks.js Outdated Show resolved Hide resolved
@patrickhulce patrickhulce merged commit d02a824 into master Mar 27, 2019
@patrickhulce patrickhulce deleted the do_not_fail_if_last_task_did_not_finish branch March 27, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants