Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: extract init() function from report-template #8228

Merged
merged 2 commits into from
Apr 12, 2019
Merged

report: extract init() function from report-template #8228

merged 2 commits into from
Apr 12, 2019

Conversation

paulirish
Copy link
Member

Providing a hook in case one uses the report-generator from a webapp (after DCL has fired).

exterkamp
exterkamp approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁✅™️

brendankenny
brendankenny approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like there's a better solution for the fundamental problem (though I don't know what it is), but this is fine in isolation

lighthouse-core/report/html/report-template.html Outdated Show resolved Hide resolved
@paulirish paulirish merged commit 2553a24 into master Apr 12, 2019
@paulirish paulirish deleted the initreport branch April 12, 2019 23:28
@exterkamp exterkamp mentioned this pull request Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @brendankenny @exterkamp