report(redesign): runtime settings footer #8229
Conversation
connorjclark
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
this was a silly time. Should be good now. |
| --header-padding: 20px 0 20px 0; | ||
| --item-bg: var(--color-black-100); | ||
| --item-padding: 10px 0px; |
There was a problem hiding this comment.
i presume item isn't specific to the env stuff?
There was a problem hiding this comment.
just checked, it's only uses for the env table. renamed.
paulirish
changed the title
|
brb deleting |
| @@ -83,6 +83,9 @@ | |||
| --circle-size: calc(3 * var(--header-font-size)); | |||
|
|
|||
| /* TODO(cjamcl) clean up unused variables. */ | |||
| --audits-margin-bottom: 40px; | |||
| --circle-size-big: 120px; | |||
| --circle-size: 96px; | |||
There was a problem hiding this comment.
what are these doing here/should we remove the circle-size above it?
oh looks like they're just alphabetized now :) still remove the one duplicate above it?
|
linking to #8185 |
|
@paulirish look good? |
|
Yup |
messed up #8192