Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(redesign): remove icons from non-pwa group headings #8329

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

connorjclark
Copy link
Collaborator

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exterkamp exterkamp added the 5.0 label Apr 16, 2019
@@ -659,36 +648,6 @@
vertical-align: middle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rule will also be removed as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it's kept for the PWA ones. ;)

@@ -659,36 +648,6 @@
vertical-align: middle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it's kept for the PWA ones. ;)

@paulirish paulirish changed the title report: remove icons in audit group headers report: remove icons from non-pwa group headings Apr 17, 2019
@paulirish paulirish changed the title report: remove icons from non-pwa group headings report(redesign): remove icons from non-pwa group headings Apr 17, 2019
@paulirish paulirish merged commit 5f11b90 into master Apr 17, 2019
@paulirish paulirish deleted the report-ui-remove-audit-group-icons branch April 17, 2019 23:15
@connorjclark connorjclark mentioned this pull request Apr 18, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants