Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(devtools): remove ascii encoded requirement #8637

Merged
merged 1 commit into from
Apr 29, 2019
Merged

clients(devtools): remove ascii encoded requirement #8637

merged 1 commit into from
Apr 29, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 26, 2019 •
edited
Loading

@connorjclark
Copy link
Collaborator Author

connorjclark commented Apr 27, 2019 •
edited
Loading

Chromium changes have landed.

brendankenny
brendankenny approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will only be a problem if we try to get changes landed in earlier chrome branches? But I assume we'd only cherry pick in those cases, so LGTM!

@brendankenny brendankenny merged commit 660cdb5 into master Apr 29, 2019
@brendankenny brendankenny deleted the dt-build-unicode branch April 29, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate devtools ascii requirement
2 participants
@connorjclark @brendankenny