Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightwallet: add 'computed/resource-summary' #8709

Merged
merged 1 commit into from
Apr 30, 2019
Merged

lightwallet: add 'computed/resource-summary' #8709

merged 1 commit into from
Apr 30, 2019

Conversation

khempenius
Copy link
Collaborator

@khempenius khempenius commented Apr 29, 2019

Summary

Related Issues/PRs
#8675, #8427, #8709, #8708,#8522, #8539

Screen Shot 2019-04-29 at 8 55 04 AM

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @khempenius thanks so much for breaking this up! made it 🍰 to review!

lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/config/budget.js Outdated Show resolved Hide resolved
lighthouse-core/test/computed/resource-summary-test.js Outdated Show resolved Hide resolved
@patrickhulce
Copy link
Collaborator

Also those dependency diagrams 🙏 ❤️

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 💯

types/budget.d.ts Show resolved Hide resolved
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is looking great. Just some surface-level types/naming/tests comments

types/budget.d.ts Outdated Show resolved Hide resolved
types/budget.d.ts Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/test/computed/resource-summary-test.js Outdated Show resolved Hide resolved
lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
@brendankenny
Copy link
Member

also the LR dependency graph is amazing

@khempenius
Copy link
Collaborator Author

Ready for review.

lighthouse-core/computed/resource-summary.js Outdated Show resolved Hide resolved
lighthouse-core/test/computed/resource-summary-test.js Outdated Show resolved Hide resolved
types/budget.d.ts Outdated Show resolved Hide resolved
@khempenius
Copy link
Collaborator Author

Updated.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit 8537a47 into GoogleChrome:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants