report(redesign): move gauge styles to main stylesheet #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i can tell you love these tests by now :)
|
| @@ -82,7 +82,6 @@ describe('DOM', () => { | |||
| const result = prepareLabData(sampleResultsStr, document); | |||
| assert.ok(result.scoreGaugeEl instanceof document.defaultView.Element); | |||
| assert.equal(result.scoreGaugeEl.querySelector('.lh-gauge__wrapper').href, ''); | |||
| assert.ok(result.scoreGaugeEl.outerHTML.includes('<style>'), 'score gauge comes with CSS'); | |||
There was a problem hiding this comment.
I assume this is ok? The PSI renderer already includes report-styles.css?
There was a problem hiding this comment.
pretty sure it does. @exterkamp to confirm
There was a problem hiding this comment.
Yup, PSI imports report-styles. Should be g2g!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8185
Fixes:
The PWA gauge depends on many style declarations defined in the template for regular gauges. When there are no regular gauges, that
styleelement never gets add. I moved all those styles to the main stylesheet to cope.