-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(plugins): add link to field-performance plugin #9051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastically written example 👍
Hi, thanks, folks :) We were so happy to have that API and really enjoyed working on the plugin. Other than #9050 #9052 I can add about html rendering. The first intention was to make performance score representation like it's for "performance" category, but digging into the code we've noticed it's not so easy without patching LH.
So then we switched to table view which we found perfect for distribution representation. What we also brainstormed about there, were:
One more, mixing static audit |
ha, it took me a while to realize you weren't sarcastically referring to @paulirish's one line change here :) Good feedback, we should capture in some issues in addition to #9053 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 🔗
Haha, yes sorry that was intended as a compliment to @denar90 and @alekseykulikov , no dig on @paulirish :) |
Hi all! In addition to @denar90's reply, I could list a few minor issues:
I have some feedback about PSI API/UI, and I will send you @paulirish by email :) |
Followup to #9049.. linking here will be useful for prospective plugin authors :)
Also...
@alekseykulikov @denar90 I was hoping to get some feedback from you guys on writing a plugin.. It looks like there were some rough edges and I think we could improve docs and perhaps some APIs to make it more straightforward for the next plugin :)
What did you notice? What was annoying? What was hard to figure out? What could we document better? :)