report: make gauge font size and positioning dynamic #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
commented
May 25, 2019
| @@ -1111,14 +1111,13 @@ | |||
|
|
|||
| .lh-gauge__percentage { | |||
| width: 100%; | |||
| height: var(--inset-size); | |||
There was a problem hiding this comment.
this wasn't defined any more. /shrug.
| position: absolute; | ||
| border-radius: inherit; |
| @@ -49,4 +49,4 @@ cp -r dist/dt-report-resources/ $fe_lh_dir | |||
| VERSION=$(node -e "console.log(require('./package.json').version)") | |||
| sed -i '' -e "s/Version:.*/Version: $VERSION/g" "$tests_dir"/*-expected.txt | |||
|
|
|||
| echo "Done. To rebase the test expectations, run: ~/chromium/src/third_party/blink/tools/run_web_tests.py --no-retry 'http/tests/devtools/audits2/*' --reset-results" | |||
| echo "Done. To rebase the test expectations, run: yarn --cwd ~/chromium/src/third_party/blink/renderer/devtools test 'http/tests/devtools/audits2/*' --reset-results" | |||
There was a problem hiding this comment.
I'm guessing the gauge size is devtools related or these would be the most random cohabitating lines I think I've seen in a long time 😆
There was a problem hiding this comment.
Definitely not related. Just a driveby.
connorjclark
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text score (eg "69") inside the gauge has had a slightly odd position.
Now its position is exactly in the half, due to a line-height: 0;
And the font-size is dynamically determined based off the circle size.