-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(gather-runner): detect Chrome interstitials #9176
Conversation
Is this something you could filter devtools logs for the appearance of |
Yeah @benschwarz the more direct way IMO would be using |
… into interstitial_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay, this is great. I also like how it has an obvious place for this to live now, so there's one place to detect and handle more interstitial special cases in the future (like if we do ever want to handle t using protocol events instead, or whatever)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
All part of the plan (#8865 (comment)).
All Chrome interstitials put the user onto
chrome-error://chromewebdata
which is then alldata
URLs under the hood. We check thedocumentURL
portion to see if they ended on the chrome error page, if they did and we had a failed request, we fail with a special cased error.Related Issues/PRs
#8865 (comment)