-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: remove commitizen as local dep #9246
Conversation
also, also, the knock-on dependency changes are kind of crazy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. i use it occasionally but w/e. not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM, I tend to end up editing the message on GH anyhoo
just to be clear, I'm pretty sure everything still works as before (with a global I don't want to make people who use |
resolved "https://registry.yarnpkg.com/fill-range/-/fill-range-2.2.4.tgz#eb1e773abb056dcd8df2bfdf6af59b8b3a936565" | ||
integrity sha512-cnrcCbj01+j2gTG921VZPnHbjmdAf8oQV/iGeV2kZxGSyfYjjTyY79ErsK1WJWMpw6DaApEX72binqJE+/d+5Q== | ||
dependencies: | ||
is-number "^2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for removing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone is worried about our deps getting too skinny, we still have another fill-range
and two versions of is-number
in here :)
There's a security vulnerability in a transitive dep of commitizen which doesn't currently have a fixed version.
Buuuut, I don't think anyone here actually uses commitizen? And even if they do, all the docs I can find instruct that it should be installed globally, and we don't provide an npm script to access the version in node_modules, so not sure why we have it in here anyways.
If anyone does use it when writing commits, that use case isn't broken since
cz-customizable
and thepackage.json
config entry are still around, so will work as is if you havecommitizen
installed globally.(also,
yarn changelog
isn't affected by this ascommitizen
is only the writing side of things andconventional-changelog
doesn't depend on it to read commit messages)