report(accessibility): add heading role to report category gauges #9422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add role="heading" with aria-level="2" to the report category gauges so screen readers can easily identify and navigate the report using headings. Level 2 was chosen because [Accessibility Insights recommends against multiple level 1 headings in the same section of a document][1]. This meets the following WCAG 2.1 success criteria 1.3.1 Info and Relationships https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships 2.4.10 Section Headings https://www.w3.org/WAI/WCAG21/quickref/#section-headings [1]: https://github.com/microsoft/accessibility-insights-web/blob/900c301e/src/content/adhoc/headings/guidance.tsx#L45-L54
johnemau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add role="heading" with aria-level="2" to the report category gauges so
screen readers can easily identify and navigate the report using headings.
Level 2 was chosen because Accessibility Insights recommends against
multiple level 1 headings in the same section of a document.
Screenshot of gauges in the devtools accessibility tree
Screenshot of NVDA Element List
This meets the following WCAG 2.1 success criteria
1.3.1 Info and Relationships https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships
2.4.10 Section Headings https://www.w3.org/WAI/WCAG21/quickref/#section-headings
Related Issues/PRs
#7575