docs(auth): running Lighthouse on authenticated pages #9628

connorjclark · 2019-08-30T16:55:21Z

https://github.com/GoogleChrome/lighthouse/blob/auth-docs/docs/authenticated-pages.md
https://github.com/GoogleChrome/lighthouse/tree/auth-docs/docs/recipes/auth

exterkamp

Thoughts on the wording of the README tutorial.

I think it is great, makes sense and is easy to follow. I have mainly only small nits for understandability. I think @kaycebasques might be better at that than me though!

docs/auth/README.md

Co-Authored-By: Shane Exterkamp <[email protected]>

brendankenny · 2019-09-03T20:51:07Z

if we follow the pattern of other docs (which has seemed good but certainly can change), it might make sense to split this into a docs/authenticated-pages.md (or whatever) that has mostly what's in the "Other Approaches" section with a new bullet point for using puppeteer with a link to docs/recipes/auth/ that has the example project and explanation

docs/auth/README.md

kaycebasques

Only had time for a brief review, but in general LGTM. I didn't see any instructional issues with the content. I didn't usability test it, though.

docs/auth/README.md

patrickhulce

looks great! ❤️

docs/auth/README.md

docs/auth/example-lh-auth.test.js

docs/auth/server/server.js

connorjclark · 2019-09-13T19:33:26Z

stashed the jest stuff in a branch, will open a new PR with that later.

This is ready for final review.

docs/recipes/auth/example-lh-auth.js

docs/recipes/auth/server/public/dashboard.html

docs/recipes/auth/server/public/unauthenticated.html

docs/recipes/auth/README.md

docs/recipes/auth/server/server.js

paulirish · 2019-09-15T20:57:30Z

docs/recipes/auth/server/server.js

+  if (req.session.user) {
+    res.sendFile('./dashboard.html', {root: PUBLIC_DIR});
+  } else {
+    res.status(401).sendFile('./unauthenticated.html', {root: PUBLIC_DIR});


if this remains a file, it should probably be named dashboard-unauthenticated.html to distinguish from an auth'd / login page.

docs/recipes/auth/server/server.js

Co-Authored-By: Paul Irish <[email protected]>

…uth-docs

connorjclark · 2019-09-16T19:17:03Z

Thoughts on using the local Lighthouse code?

diff --git a/docs/recipes/auth/package.json b/docs/recipes/auth/package.json
index 1dcdb4625..b632de6bb 100644
--- a/docs/recipes/auth/package.json
+++ b/docs/recipes/auth/package.json
@@ -5,7 +5,7 @@
   "dependencies": {
     "express": "^4.17.1",
     "express-session": "^1.16.2",
-    "lighthouse": "^5.2.0",
+    "lighthouse": "file:../../..",
     "morgan": "^1.9.1"
   }
 }

plus, adding a sanity test that this works in CI?

cd docs/recipes/auth
yarn
yarn concurrently start "node example-lh-auth.js"

paulirish · 2019-09-18T23:36:59Z

Thoughts on using the local Lighthouse code?

sure. sg.

plus, adding a sanity test that this works in CI?

can you add that in a followup PR?

docs/recipes/auth/README.md

docs/recipes/auth/example-lh-auth.js

connorjclark · 2019-09-19T18:18:44Z

@patrickhulce i think you're change requests were all addressed so I am dismissing your review since you are on vacation :)

vaca

connorjclark added 5 commits August 29, 2019 19:55

init

aecfd9f

start doc

6aa9c08

update

69adf71

update

5757985

update

0ae9040

connorjclark requested a review from paulirish as a code owner August 30, 2019 16:55

googlebot added the cla: yes label Aug 30, 2019

lint

5469beb

vercel bot deployed to staging August 30, 2019 16:57 View deployment

fix test

59aa12f

vercel bot deployed to staging August 30, 2019 17:36 View deployment

cdt

eadc8e0

vercel bot deployed to staging August 30, 2019 17:48 View deployment

Update README.md

6ac8d37

vercel bot deployed to staging August 30, 2019 17:50 View deployment

exterkamp reviewed Aug 30, 2019

View reviewed changes

Update docs/auth/README.md

f268134

Co-Authored-By: Shane Exterkamp <[email protected]>

vercel bot deployed to staging August 30, 2019 18:05 View deployment

changes

06dd0b0

vercel bot deployed to staging August 30, 2019 18:10 View deployment

changes

5e460a5

vercel bot deployed to staging August 30, 2019 18:16 View deployment

changes

b54a4ac

vercel bot deployed to staging August 30, 2019 18:19 View deployment

just run seo

ae5f2e5

vercel bot deployed to staging August 30, 2019 18:28 View deployment

brendankenny reviewed Sep 3, 2019

View reviewed changes

docs/auth/README.md Outdated Show resolved Hide resolved

kaycebasques approved these changes Sep 3, 2019

View reviewed changes

docs/auth/README.md Outdated Show resolved Hide resolved

docs/auth/README.md Outdated Show resolved Hide resolved

docs/auth/README.md Outdated Show resolved Hide resolved

patrickhulce previously requested changes Sep 4, 2019

View reviewed changes

paulirish reviewed Sep 15, 2019

View reviewed changes

Apply suggestions from code review

cfa14b9

Co-Authored-By: Paul Irish <[email protected]>

vercel bot deployed to staging September 16, 2019 18:53 View deployment

connorjclark added 2 commits September 16, 2019 11:57

pr

826f855

Merge branch 'auth-docs' of github.com:GoogleChrome/lighthouse into a…

3dc265b

…uth-docs

vercel bot deployed to staging September 16, 2019 18:58 View deployment

pr

c5d3cda

vercel bot deployed to staging September 16, 2019 19:03 View deployment

files

e3b520f

vercel bot temporarily deployed to staging September 16, 2019 19:09 Inactive

pr

e389e28

vercel bot deployed to staging September 16, 2019 19:10 View deployment

use local lh

97b4dac

vercel bot deployed to staging September 18, 2019 23:43 View deployment

paulirish approved these changes Sep 18, 2019

View reviewed changes

docs/recipes/auth/README.md Show resolved Hide resolved

docs/recipes/auth/example-lh-auth.js Show resolved Hide resolved

update

a6ceaa2

vercel bot deployed to staging September 19, 2019 17:55 View deployment

connorjclark merged commit e7a9b5f into master Sep 19, 2019

connorjclark deleted the auth-docs branch September 19, 2019 18:19

This was referenced Sep 24, 2019

Question: How to test page behind authentication? #1418

Closed

Question: Auth #9569

Closed

paulirish pushed a commit that referenced this pull request Nov 6, 2019

docs(auth): running Lighthouse on authenticated pages (#9628)

4a507fa

connorjclark mentioned this pull request Nov 20, 2019

docs(integration-tests): using Lighthouse with Jest; verify in our CI #9722

Merged

snyk-bot mentioned this pull request Mar 21, 2020

[Snyk] Upgrade lighthouse from 5.1.0 to 5.6.0 godaddy/lighthouse4u#13

Merged

snyk-bot mentioned this pull request Mar 6, 2023

[Snyk] Upgrade puppeteer-core from 3.3.0 to 19.7.0 Benjamin-KY/lighthouse#13

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(auth): running Lighthouse on authenticated pages #9628

docs(auth): running Lighthouse on authenticated pages #9628

connorjclark commented Aug 30, 2019 •

edited by paulirish

Loading

exterkamp left a comment

brendankenny commented Sep 3, 2019

kaycebasques left a comment

patrickhulce left a comment

connorjclark commented Sep 13, 2019

paulirish Sep 15, 2019

connorjclark commented Sep 16, 2019

paulirish commented Sep 18, 2019

connorjclark commented Sep 19, 2019

docs(auth): running Lighthouse on authenticated pages #9628

docs(auth): running Lighthouse on authenticated pages #9628

Conversation

connorjclark commented Aug 30, 2019 • edited by paulirish Loading

exterkamp left a comment

Choose a reason for hiding this comment

brendankenny commented Sep 3, 2019

kaycebasques left a comment

Choose a reason for hiding this comment

patrickhulce left a comment

Choose a reason for hiding this comment

connorjclark commented Sep 13, 2019

paulirish Sep 15, 2019

Choose a reason for hiding this comment

connorjclark commented Sep 16, 2019

paulirish commented Sep 18, 2019

connorjclark commented Sep 19, 2019

connorjclark commented Aug 30, 2019 •

edited by paulirish

Loading