Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(import): web.dev links and small corrections #9846

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

exterkamp
Copy link
Member

Summary
Automatic import of tc/ strings, 90% web.dev links, 10% other.

meta: I wanted to import this to keep the import PR's small, since a big one is coming for Stack Packs.

@connorjclark
Copy link
Collaborator

connorjclark commented Oct 15, 2019

one day, could we have some sanity checks for these locale files? I am thinking:

  1. parse the english strings for markdown links / code snippets, and ensure each language has the same number
  2. more?

@patrickhulce
Copy link
Collaborator

patrickhulce commented Oct 16, 2019

I like these ideas @connorjclark :)

I wanted to import this to keep the import PR's small, since a big one is coming for Stack Packs.

that's very kind of you @exterkamp, but fwiw I'm not sure what that really does. as it stands I'm not sure we fully review the 2k lines of change when they're "small" 😆

EDIT: I say this because I'm afraid I might have misunderstood the review burden here, what are we intended to examine with these other than loosely scanning that things look OK?

@brendankenny
Copy link
Member

  • parse the english strings for markdown links / code snippets, and ensure each language has the same number

we almost have this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants