Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom host with pubsub #2330

Merged
merged 4 commits into from
May 25, 2017
Merged

Allow for custom host with pubsub #2330

merged 4 commits into from
May 25, 2017

Conversation

mkamioner
Copy link
Contributor

When using the emulator, I don't want to be restricted to using the environment variable of PUBSUB_EMULATOR_HOST - Especially when I have certain topics in the cloud and other in an emulator.

This will allow the programmer to decide what host to use easily

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 24, 2017
@mkamioner
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 24, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c519c37 on mkamioner:master into 13ec5fe on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Thank you for this! We support this in the Datastore API, but haven't brought it over here yet, so your help is appreciated!

To match what's going on in Datastore, could you rename host to apiEndpoint? You can see (and please add) the JSDocs description here: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/13ec5fef0da92b74e7adf7a2479f8c1636be72d4/packages/datastore/src/index.js#L61

And if you're up for it, we could use some tests as well. You can probably get by with copying what we have in Datastore: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/13ec5fef0da92b74e7adf7a2479f8c1636be72d4/packages/datastore/test/index.js#L363 -- if you'd rather have me do it, no problem, just let me know.

Thanks again!

@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label May 24, 2017
@mkamioner
Copy link
Contributor Author

@stephenplusplus - Happily! I will do it now!

Happy to contribute :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 44f70df on mkamioner:master into 13ec5fe on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 77fd27e into googleapis:master May 25, 2017
@stephenplusplus
Copy link
Contributor

It's perfect, thank you very much again!

@mkamioner
Copy link
Contributor Author

Honor and a pleasure :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants