Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: fix broken system test #2425

Merged
merged 1 commit into from
Jun 30, 2017
Merged

spanner: fix broken system test #2425

merged 1 commit into from
Jun 30, 2017

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Jun 30, 2017 •
edited
Loading

Closes #2397

@callmehiphop callmehiphop added the api: spanner Issues related to the Spanner API. label Jun 30, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2017
callmehiphop
callmehiphop commented Jun 30, 2017
View reviewed changes
packages/spanner/system-test/spanner.js
@@ -2716,7 +2716,7 @@ var spanner = new Spanner(env);
transaction.run('SELECT * FROM TxnTable', function(err, rows) {
assert.ifError(err);

assert.strictEqual(rows.length, 2);
assert.strictEqual(rows.length, 1);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@callmehiphop
Copy link
Contributor Author

/cc @swcloud

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.988% when pulling c775ab7 on callmehiphop:dg--spanner-test into c9037b6 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit f527445 into googleapis:master Jun 30, 2017
This was referenced Jul 5, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcloud swcloud swcloud left review comments

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@callmehiphop @coveralls @stephenplusplus @swcloud @googlebot