Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Combining comma above right" character needs spacing #363

Closed
dlevineBC opened this issue Apr 10, 2019 · 4 comments
Closed

"Combining comma above right" character needs spacing #363

dlevineBC opened this issue Apr 10, 2019 · 4 comments

Comments

@dlevineBC
Copy link

Defect Report

Use this template for filing a defect report. For feature requests and other matters, you can use part of the template and delete what you don't need.

Title

When using the 'combining comma above right' U+0315, the comma squishes into the next character to the right. This is required for the Kwak̓wala language specifically between the characters of k'w, t's, and t'ł

Font

NotoSans-Regular.ttf

OS name and version

Example is shown on Chrome using Mac

Character data

t̕s
U+74 U+315 U+73

Screenshot

Here is the bug in rendering
ts

Here is how it is supposed to be rendered
proper-ts

@nizarsq
Copy link

nizarsq commented Jul 1, 2020

Look like this issue has been resolved in the current NotoSans. Please use the font in this directory to verify the fix https://github.com/googlefonts/noto-fonts/tree/master/phaseIII_only/hinted/ttf/NotoSans
Screen Shot 2020-07-01 at 3 02 06 PM

@nizarsq nizarsq closed this as completed Jul 1, 2020
@moyogo
Copy link
Contributor

moyogo commented Jul 2, 2020

@nizarsq the test string in the screenshots seems to be "k'w, t's, and t'ł" (with U+0027) instead of "k̕w, t̕s, and t̕ł" (with U+0315). @dlevineBC had provided "t̕s" U+74 U+315 U+73 in the character data but mentioned "k'w, t's, and t'ł" (with U+0027) in the issue title. That said the issue is fixed indeed.

@nizarsq
Copy link

nizarsq commented Jul 2, 2020

@moyogo Thank you for the correction. Apparently I used the characters set @dlevineBC provided. I was not expecting to see (U+0027) APOSTROPHE when the issue is with U+0315 (COMMA). The good thing this issue has been resolved.

@nizarsq
Copy link

nizarsq commented Jul 2, 2020

Screen Shot 2020-07-02 at 7 39 09 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants