Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health messages logged with wrong severity #335

Closed
steven-supersolid opened this issue Aug 31, 2018 · 2 comments
Closed

Health messages logged with wrong severity #335

steven-supersolid opened this issue Aug 31, 2018 · 2 comments
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Milestone

Comments

@steven-supersolid
Copy link
Collaborator

Running in GKE and viewing logs in Stackdriver Logging, health message logs are still seen when the log filter level is set to Error. The level inside the message is "info" but severity is "ERROR"

E.g.
2018-08-31 17:16:44.000 BST {"msg":"Health Ping Received","level":"info","source":"*gameservers.SDKServer"}

{
 insertId:  "7i33dlfktfmsv"  
 jsonPayload: {…}  
 labels: {…}  
 logName:  "projects/xxx/logs/agones-gameserver-sidecar"  
 receiveTimestamp:  "2018-08-31T16:16:46.466567315Z"  
 resource: {…}  
 severity:  "ERROR"  
 timestamp:  "2018-08-31T16:16:44Z"  
}

Not sure if this is a bug with Agones or a project configuration issue.

@markmandel
Copy link
Member

I actually think all logs in gke come through as Error level (not sure why) - but will double check.

@markmandel
Copy link
Member

https://cloud.google.com/kubernetes-engine/docs/how-to/logging#best_practices

"Severities: By default, logs written to the standard output are on the INFO level and logs written to the standard error are on the ERROR level. Structured logs can include a severityfield, which defines the log's severity. glog-formatted logs' severity is set automatically"

I wonder if logrus is misconfigured to output on stderr?

Will investigate!

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Aug 31, 2018
@markmandel markmandel added this to the 0.5.0 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Projects
None yet
Development

No branches or pull requests

2 participants