Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Style Guide #109

Open
zghera opened this issue Jul 28, 2020 · 0 comments
Open

Import Style Guide #109

zghera opened this issue Jul 28, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@zghera
Copy link
Collaborator

zghera commented Jul 28, 2020

Issue summary

Consistent import ... statements throughout the project.

Expected behavior

The general groupings should be:

import React ...
any other react specific imports (ex: react-router-dom)

React bootstrap, Firestore, other 3rd party imports

Local file imports

Within each of the sections, the order of the import "types" should be from least to most specific. Example:

import 'file.js';
import * as File from 'file.js';
import File from 'file.js';
import { Func } from 'file.js';

Actual behavior

Inconsistencies between (and potentially within) the user auth, activities, and trips sections of SLURP. First pointed out in PR #82 comments.

@zghera zghera added the enhancement New feature or request label Jul 28, 2020
@zghera zghera mentioned this issue Jul 28, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants