Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Test for firebaseTsFromISO() in time.js #118

Open
zghera opened this issue Jul 30, 2020 · 0 comments
Open

Fix Broken Test for firebaseTsFromISO() in time.js #118

zghera opened this issue Jul 30, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zghera
Copy link
Collaborator

zghera commented Jul 30, 2020

Issue summary

Because Timestamp was mocked in time.test.js the new test for firebaseTsFromISO fails because the constructor for Timestamp is not mocked. So constructor either needs to also be mocked or a workaround for using the real constructor in this test should be found (maybe something like this).

Expected behavior

Test firestore Timestamp format test in time.test.js passes.

Actual behavior

Test firestore Timestamp format test in time.test.js fails.

@zghera zghera added the bug Something isn't working label Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants