Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Log Statements #93

Open
zghera opened this issue Jul 21, 2020 · 0 comments
Open

Remove Log Statements #93

zghera opened this issue Jul 21, 2020 · 0 comments
Assignees
@anan-ya-y @keiffer01 @zghera
Labels
enhancement New feature or request

Comments

@zghera
Copy link
Collaborator

zghera commented Jul 21, 2020 •
edited
Loading

Issue summary

Remove any console.log() statements in the frontend to avoid providing users information to potentially reverse engineer and break into SLURP.

Expected behavior

No external logging: console.log statements. Ideally, any important info or error logs should be added on the backend (Java servlets) or other logging system that is not visible externally.

Actual behavior

The current implementation contains many console.log statements (especially in the ViewTrips components).
@zghera zghera added the enhancement New feature or request label Jul 21, 2020
@zghera zghera mentioned this issue Jul 24, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anan-ya-y anan-ya-y

@keiffer01 keiffer01

@zghera zghera

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anan-ya-y @keiffer01 @zghera