Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert getErrorElement() to React Component #98

Open
zghera opened this issue Jul 23, 2020 · 0 comments
Open

Convert getErrorElement() to React Component #98

zghera opened this issue Jul 23, 2020 · 0 comments
Assignees
@zghera
Labels
enhancement New feature or request

Comments

@zghera
Copy link
Collaborator

zghera commented Jul 23, 2020

Issue summary

Convert the function getErrorElement in trips-container.js to component in the Error directory once PR #77 is merged.

Expected behavior

When an error occurs in grabbing the trips container, set the state of trips to a new error component created from getErrorElement.

Actual behavior

When an error occurs in grabbing the trips container, set the state of of trips to the result of the function call to getErrorElement.
@zghera zghera added the enhancement New feature or request label Jul 23, 2020
@zghera zghera self-assigned this Jul 23, 2020
@zghera zghera changed the title Convert getErrorElement() to component Convert getErrorElement() to React Component Jul 23, 2020
@zghera zghera mentioned this issue Jul 23, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zghera zghera

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zghera