-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copies some snippets that were in v3 only to gms #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: the java compatibility version
…collision behavior
…maps-samples/android-samples into feat/copy_snippets_to_gms
kikoso
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We increased Java through the repo to 21.
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kikoso
added a commit
that referenced
this pull request
Aug 14, 2024
* feat: copies some snippets that were in v3 only to gms chore: the java compatibility version * fix: updates copyright dates and adds missing copyright * fix: copyright header for strings.xml * fix: set Java Version back to 17 * fix: set Java Version back to 17 * fix: set Java Version back to 17 * fix: set Java Version back to 17 * fix: set Java Version back to 17 * feat: creates AdvancedMarkersCollisionActivity to demonstrate marker collision behavior * chore: not adding jar files in libs directory * feat: set Java 21 everywhere --------- Co-authored-by: Enrique López Mañas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: the java compatibility version
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕