Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply styling options for iOS navigation view #248

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Sep 5, 2024

Setting navigation view colors only works if the view has an active navigation session running. This PR modifies how map styling is controlled in the native iOS code. The styling data is now stored and applied to the navigation view after the navigation session is attached.

Fixes #246

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@jokerttu jokerttu changed the title fix: apply styling options after navigation session fix: apply styling options for iOS navigation view Sep 5, 2024
Copy link
Contributor

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu merged commit 32dd6b3 into googlemaps:main Sep 9, 2024
11 checks passed
@jokerttu jokerttu deleted the fix/ios-styling branch September 10, 2024 13:05
@jokerttu jokerttu restored the fix/ios-styling branch October 15, 2024 09:21
@jokerttu jokerttu deleted the fix/ios-styling branch October 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Styling not working in the current example app
3 participants