feat: update navigation sdk versions (iOS -> 9.1.2, Android -> 6.0.0) and min iOS version to 15 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoSalazarB16
approved these changes
Oct 21, 2024
| @@ -76,6 +76,6 @@ dependencies { | |||
| implementation 'com.facebook.react:react-native:+' | |||
| implementation 'com.android.support:multidex:1.0.3' | |||
| implementation 'androidx.constraintlayout:constraintlayout:2.1.4' | |||
| implementation "com.google.android.libraries.navigation:navigation:5.3.1" | |||
| implementation "com.google.android.libraries.navigation:navigation:6.0.0" | |||
There was a problem hiding this comment.
Nit: do we not define a specific KT/KGP version here? should we?
There was a problem hiding this comment.
I updated the gradle version to 8.4.0 just like in the Flutter SDK.
As for Kotlin and Kotlin Gradle Plugin...I'm not sure if we need those definitions since our SDK is written in Java. That being said, adding those didn't cause any issues and maybe it's more future proof that way so I added them as well.
jokerttu
force-pushed
the
feat/update-navigation-sdk
branch
from
1961450
to
496c8e5
Compare
jokerttu
force-pushed
the
feat/update-navigation-sdk
branch
from
496c8e5
to
1392b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Android and iOS nav SDK versions to latest and bump iOS min version to 15.