This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Use Kotlin Coroutines for IO executor #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinyueZ
force-pushed
the
feature/coroutines-app-executors
branch
from
1368825
to
e7d6a65
Compare
tiembo
suggested changes
Nov 6, 2018
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/ScopedViewModel.kt
Outdated
Show resolved
Hide resolved
|
@tiembo I needs more information from your side to complete next change 😕 |
XinyueZ
force-pushed
the
feature/coroutines-app-executors
branch
from
83a04ab
to
a827fb8
Compare
Addressed by android#235 (comment)
|
@tiembo I have completed the changes-request. |
tiembo
suggested changes
Nov 16, 2018
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/PlantDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/ScopedViewModel.kt
Outdated
Show resolved
Hide resolved
XinyueZ
force-pushed
the
feature/coroutines-app-executors
branch
from
7474aec
to
4887e15
Compare
…/XinyueZ/android-sunflower into feature/coroutines-app-executors
XinyueZ
force-pushed
the
feature/coroutines-app-executors
branch
from
4887e15
to
9b5309d
Compare
|
@tiembo I have solved changes request 😀 |
objcode
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
Awesome PR! Nice work.
Author of coroutines codelab here. @tiembo asked me to take a look for coroutines style. Everything is correct as written however I've made some style requests based on our style of starting in the Main dispatcher and guarding functions that do IO using withContext.
I'll take another look for LGTM when that's in!
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/PlantDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/PlantDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/data/GardenPlantingRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/data/GardenPlantingRepository.kt
Outdated
Show resolved
Hide resolved
|
@objcode thx, I will update slightly later. |
…flower into feature/coroutines-app-executors
|
@objcode done |
tiembo
suggested changes
Nov 27, 2018
app/src/main/java/com/google/samples/apps/sunflower/data/GardenPlantingRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/data/GardenPlantingRepository.kt
Outdated
Show resolved
Hide resolved
|
Coroutine style is +1! Thanks |
XinyueZ
force-pushed
the
feature/coroutines-app-executors
branch
from
5d1f97f
to
076f51c
Compare
|
@tiembo done, reverted. |
tiembo
approved these changes
Nov 28, 2018
|
Thank you @XinyueZ ! Added this PR to the Notable Community Contributions wiki page 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runOnIoThread(), sorry @tiembo 😸 .