From 454051384bdede67b2298ef0a63572de5b3e58df Mon Sep 17 00:00:00 2001 From: Sam Stern Date: Tue, 15 Jan 2019 14:10:16 -0800 Subject: [PATCH] Respond to review comments Change-Id: Ie03a23b5b04af5146b887101566d765315cad356 --- build.gradle | 2 +- .../easypermissions/EasyPermissionsLowApiTest.java | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/build.gradle b/build.gradle index 93ae46b..e8c967d 100644 --- a/build.gradle +++ b/build.gradle @@ -31,7 +31,7 @@ ext { mavenGroup = 'pub.devrel' mavenArtifactId = 'easypermissions' - mavenVersion = '2.0.0' + mavenVersion = '2.0.1-SNAPSHOT' bintrayOrg = 'easygoogle' diff --git a/easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java b/easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java index 6d2f9c8..e40d107 100644 --- a/easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java +++ b/easypermissions/src/test/java/pub/devrel/easypermissions/EasyPermissionsLowApiTest.java @@ -39,10 +39,10 @@ public class EasyPermissionsLowApiTest { Manifest.permission.READ_SMS, Manifest.permission.ACCESS_FINE_LOCATION}; private TestActivity spyActivity; - private TestAppCompatActivity spySupportActivity; + private TestAppCompatActivity spyAppCompatActivity; private TestFragment spyFragment; private ActivityController activityController; - private ActivityController supportActivityController; + private ActivityController appCompatActivityController; private SupportFragmentController supportController; @Captor private ArgumentCaptor integerCaptor; @@ -84,9 +84,9 @@ public void shouldCallbackOnPermissionGranted_whenRequestFromActivity() { @Test public void shouldCallbackOnPermissionGranted_whenRequestFromSupportActivity() { - EasyPermissions.requestPermissions(spySupportActivity, RATIONALE, TestAppCompatActivity.REQUEST_CODE, ALL_PERMS); + EasyPermissions.requestPermissions(spyAppCompatActivity, RATIONALE, TestAppCompatActivity.REQUEST_CODE, ALL_PERMS); - verify(spySupportActivity, times(1)) + verify(spyAppCompatActivity, times(1)) .onPermissionsGranted(integerCaptor.capture(), listCaptor.capture()); assertThat(integerCaptor.getValue()).isEqualTo(TestAppCompatActivity.REQUEST_CODE); assertThat(listCaptor.getValue()).containsAllIn(ALL_PERMS); @@ -105,19 +105,19 @@ public void shouldCallbackOnPermissionGranted_whenRequestFromFragment() { private void setUpActivityAndFragment() { activityController = Robolectric.buildActivity(TestActivity.class) .create().start().resume(); - supportActivityController = Robolectric.buildActivity(TestAppCompatActivity.class) + appCompatActivityController = Robolectric.buildActivity(TestAppCompatActivity.class) .create().start().resume(); supportController = SupportFragmentController.of(new TestFragment()) .create().start().resume(); spyActivity = Mockito.spy(activityController.get()); - spySupportActivity = Mockito.spy(supportActivityController.get()); + spyAppCompatActivity = Mockito.spy(appCompatActivityController.get()); spyFragment = Mockito.spy(supportController.get()); } private void tearDownActivityAndFragment() { activityController.pause().stop().destroy(); - supportActivityController.pause().stop().destroy(); + appCompatActivityController.pause().stop().destroy(); supportController.pause().stop().destroy(); } }