Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I got this compile error #160

Closed
cheyiliu opened this issue Sep 8, 2017 · 7 comments
Closed

I got this compile error #160

cheyiliu opened this issue Sep 8, 2017 · 7 comments

Comments

@cheyiliu
Copy link

cheyiliu commented Sep 8, 2017

Error:(3610) Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.DayNight.DarkActionBar'.

@SUPERCILEX
Copy link
Contributor

@cheyiliu Oh shoot, that would be my fault. As a workaround, you can add this dependency:

implementation "com.android.support:appcompat-v7:$support_library_version"

@samtstern Should we make AppCompat an api dependency or force devs to add it manually?

@cheyiliu
Copy link
Author

cheyiliu commented Sep 8, 2017

@SUPERCILEX thanks

@samtstern
Copy link
Contributor

@SUPERCILEX we shouldn't force anyone to add it manually, so we should probably change it back to an api dependency.

@SUPERCILEX
Copy link
Contributor

@samtstern oh well, see #161

@samtstern samtstern reopened this Sep 8, 2017
@samtstern samtstern added this to the 1.0.1 milestone Sep 8, 2017
@samtstern
Copy link
Contributor

@cheyiliu this will be in version 1.0.1 but you can fix it for now by adding a dependency on your app on appcompat-v7.

@bangbing
Copy link

waiting for 1.0.1 ^^@samtstern

@samtstern
Copy link
Contributor

Version 1.0.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants