Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

POM file does not declare dependencies #187

Closed
samtstern opened this issue Dec 13, 2017 · 2 comments · Fixed by #188
Closed

POM file does not declare dependencies #187

samtstern opened this issue Dec 13, 2017 · 2 comments · Fixed by #188

Comments

@samtstern
Copy link
Contributor

The pom.xml file for EasyPermissions 1.1.0 looks like this:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>pub.devrel</groupId>
  <artifactId>easypermissions</artifactId>
  <version>1.1.0</version>
  <packaging>aar</packaging>
  <name>EasyPermissions</name>
  <description>A wrapper library for basic Android M system permissions logic</description>
  <url>https://github.com/googlesamples/easypermissions</url>
  <inceptionYear>2015</inceptionYear>
  <licenses>
    <license>
      <name>The Apache Software License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <name>Google</name>
    </developer>
  </developers>
  <scm>
    <connection>https://github.com/googlesamples/easypermissions.git</connection>
    <url>https://github.com/googlesamples/easypermissions</url>
  </scm>
</project>

There's no dependencies section! This means that we're gonna run into bugs like #184 by not properly warning the dependency system about what we need.

@SUPERCILEX
Copy link
Contributor

Well that's an oopsies! 😀 I believe upgrading this dependency to 2.0 will fix it, but I couldn't find a way to generate a POM file locally.

@samtstern
Copy link
Contributor Author

I have a fix coming now 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants