Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing EditorSpinSlider as SpinSlider #81

Open
sairam4123 opened this issue May 24, 2021 · 1 comment
Open

Exposing EditorSpinSlider as SpinSlider #81

sairam4123 opened this issue May 24, 2021 · 1 comment
Labels
feature 💡 New feature proposal topic:gui

Comments

@sairam4123
Copy link

Describe the limitation you are having in your project
I'm currently writing a custom property editor in GDScript, I don't have access to EditorSpinSlider

Describe the enhancement and how it helps to overcome the limitation
Exposing SpinSlider, this is one way, I think it is easy to expose SpinSlider

How difficult it is to workaround the limitation?
Write your own SpinSlider (difficult) in GDScript ;)

@sairam4123 sairam4123 added the enhancement Improvement of existing features label May 24, 2021
@Xrayez
Copy link
Contributor

Xrayez commented May 24, 2021

Looks like there's existing Godot proposal for this: godotengine/godot-proposals#2068.

I'm not sure whether it would be easy to expose the class to be available in non-editor builds without reimplementing the entire class in Goost (it would basically lead to copy-paste of the class, which is indeed easy to do, but may not as easy to maintain), which may be OK to do if further enhancements and properties need to be exposed.

That said, it would be much-much easier to expose this class in Godot directly, but yeah I'm not against this feature, especially when this class would complement existing SpinBox class, apparently. Yet any fixes and enhancements would need to be synchronized with Godot's implementation manually that way, which may be PITA. 😅

This is also a general problem of "editor vs scene/core" regarding editor GUI classes: godotengine/godot-proposals#2063. If Godot could implement godotengine/godot-proposals#2063 as a compile-time option, then it would be easy to take advantage of this mechanism to be available in official Goost builds. Godot aims to keep its binary sizes small for their official builds, this is why you don't see SpinSlider in Godot, and many others. 😛

@Xrayez Xrayez changed the title Exposing EditorSpinSlider as SpinSlider Exposing EditorSpinSlider as SpinSlider May 24, 2021
@Xrayez Xrayez added feature 💡 New feature proposal and removed enhancement Improvement of existing features labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 New feature proposal topic:gui
Projects
None yet
Development

No branches or pull requests

2 participants