Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

When enabling 'auto whitelist' cannot disable per-site #221

Open
insanitybit opened this issue Apr 4, 2014 · 1 comment
Open

When enabling 'auto whitelist' cannot disable per-site #221

insanitybit opened this issue Apr 4, 2014 · 1 comment

Comments

@insanitybit
Copy link

So if you enable the 'auto whitelist first party domain' rule you can't go to a website, unwhitelist the domain, lock it, and then have it persist. If you reload that domain will be whitelisted again.

I think the expected behavior of the user is that the domain would be whitelisted upon first visit, but not be some permanent setting.

@gorhill
Copy link
Owner

gorhill commented Apr 18, 2014

Problem is that a "graylist" state is represented internally by the absence of rules, the default state of all cell. Thus un-whitelisting is essentially the removal of a rule, which put back the cell in its default state -- this is also why there is no visual at all for the persisted state of a graylisted cell.

In short, at this point I don't know how I would solve this issue. Need to think more.

Edit: Was there a scope in this particular case? If there is a scope, I can envision a solution where an internal switch per-scope would allow to disable auto-whitelist just for that particular scope.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants