New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element picker: a selected element with width or height of zero should fall back on dimensions of child elements #1024

Closed

gorhill opened this issue Dec 7, 2015 · 0 comments

Owner

gorhill commented Dec 7, 2015

Repro steps:

Go to https://en.wikipedia.org/wiki/Main_Page.
- Be sure cookies are cleared beforehand -- so as to ensure the large funding notice at the top is displayed.
Enter element picker.
Select the large notice at the top.
In the element picker dialog box, pick ###centralNotice

Result:

Nothing is highlighted, merely only the contour of a zero-height box.

Fix:

The element picker should fall back on the descendants width/height for when a highlighted element has a width or height of zero.

The text was updated successfully, but these errors were encountered:

gorhill closed this as completed in

85dcf6e

gorhill added a commit that referenced this issue


          code review re. #1024

c3aadde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment