Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Ctlr-click' text hint in Element picker mode should be 'Cmd-click' for macOS #2338

Closed
z0rc opened this issue Jan 25, 2017 · 5 comments
Closed

Comments

@z0rc
Copy link

z0rc commented Jan 25, 2017

Describe the issue

Right now hint next to 'Cosmetic filters' says Click, Ctlr-click, this is true for Windows and Linux, but on macOS Ctlr-click doesn't work as expected, if brings up a Firefox context menu. You actually have to use Cmd-click to archive the same result as Ctrl-click on Linux.

One or more specific URLs where the issue occurs

N/A

Screenshot in which the issue can be seen

screen shot 2017-01-25 at 16 27 23

Steps for anyone to reproduce the issue

  1. Switch to element picker mode
  2. Select anything
  3. Observe

Your settings

  • Browser/version: Firefox Dev Edition (52.0a2)
  • uBlock Origin version: 1.10.4
Your filter lists

N/A

Your custom filters (if any)

N/A

@Snapy
Copy link

Snapy commented Jan 25, 2017

Already fixed.

@gorhill
Copy link
Owner

gorhill commented Jan 25, 2017

Fixed for Safari, but not for other browsers on MacOS.

@gorhill
Copy link
Owner

gorhill commented Jan 25, 2017

Essentially duplicate of #614.

@uBlock-user
Copy link
Contributor

uBlock-user commented Jan 26, 2017

That fix won't work if the uBlock-Safari repo inherits all of upstream repo's changes with every release, so the fix has to be made in the upstream repo itself.

@quantumgolem
Copy link

@gorhill Why don't you close this issue then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants