Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent change to adminSettings? #2419

Closed
jocooza opened this issue Mar 1, 2017 · 1 comment
Closed

Recent change to adminSettings? #2419

jocooza opened this issue Mar 1, 2017 · 1 comment

Comments

@jocooza
Copy link

jocooza commented Mar 1, 2017

I have been using uBlock Origin with adminSettings and the following JSON string for a long time:

{"userSettings": {"advancedUserEnabled": true},"filterLists": {"https://easylist-downloads.adblockplus.org/fanboy-social.txt": {"off": false}},"dynamicFilteringString": "* * inline-script block\n* * 1p-script block\n* * 3p-script block\n* * 3p-frame block"}

This would result in all default 3rd-party filters, plus Fanboy's Social Blocking list being enabled.

Some time ago I noticed ads weren't being blocked on YouTube, but I didn't look further into it as first there didn't seem to be any problems on other sites (probably because I don't run Javascript by default). However, I have now investigated the problem and found out the only filter enabled is Fanboy's Social Blocking list.

The following string makes everything work as expected, and maybe it's more resilient in case of the filter moving to a new URL:

{"userSettings":{"advancedUserEnabled":true},"selectedFilterLists":["plowe-0","fanboy-social","malware-1","malware-0","easyprivacy","easylist","ublock-unbreak","ublock-privacy","ublock-badware","ublock-filters","user-filters"],"dynamicFilteringString":"* * inline-script block\n* * 1p-script block\n* * 3p-script block\n* * 3p-frame block"}

Can anyone tell when the change that made my configuration not work was introduced into uBlock Origin? I would like to know how long my systems have been vulnerable while not being protected by the default filters.

Browser: Firefox 51.0.1
Ublock Origin: 1.11.0

@gorhill
Copy link
Owner

gorhill commented Mar 1, 2017

1.11.0, see #2314.

Looks like I did not test properly converting the old filter lists representation to the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants