Newly created filter through the element picker is ignored after quitting/launching uBO

[gorhill]

Describe the issue

When a certain number of conditions are met, creating a filter through the element picker can cause that filter to not be applied next time uBO is launched.

Conditions:

• There must be a valid selfie in use.

  • A selfie is created after 23 minutes where no filter changes occur (updating lists, editing My filters, changing the set of lists, etc).

• Once a selfie is present and valid, a filter must be created through the element picker.

• The user must quit uBO before 23 minutes has elapsed.

One or more specific URLs where the issue occurs

http://blog.planet5d.com/

Steps for anyone to reproduce the issue

• Wait for a selfie to be present and valid (leave uBO idle for 24 minutes).
• Open http://blog.planet5d.com/ (no existing filter at time of writing to take care of these ads)
• Open the element picker and add ##.g to the input field.
  • As a result, all the ads on the page will be highlighted
• Click the Create button.
  • Ads disappear. Forcing a reload confirms that the new filter works fine.
• Quit uBO.
• Launch uBO.
• Navigate to the web page above.

Result: ads are showing. The filter last created is seemingly ignored. This is caused by the fact that uBO used the non-invalidated selfie to load its data, and the new filter is not part of that selfie, which should have been invalidated when the filter was created.

Your settings

Default settings.

• OS/version: Any.
• Browser/version: Any.
• uBlock Origin version: 1.12.3.

Your filter lists

Default lists.

[gorhill]

This is a regression bug as a result of asset management refactoring. The invalidation of the selfie used to be done properly in the current scenario:

uBlock/src/js/storage.js

Line 1039 in ee4fc2a

this.selfieManager.destroy();

.