Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugzilla issues affecting uBlock Origin webext #2795

Closed
gorhill opened this issue Jul 19, 2017 · 8 comments
Closed

Bugzilla issues affecting uBlock Origin webext #2795

gorhill opened this issue Jul 19, 2017 · 8 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Jul 19, 2017

A placeholder issue to track all open issues on bugzilla.mozilla.org affecting the webext version of uBlock Origin:

  • ~1367494: [BrowserAction] properties supported on desktop but not android should warn rather than prevent installation~~
    • This is what is preventing uBO/webext from being installed on Firefox for Android.
    • uBO/webext can't be released on the stable channel of AMO as long as the fix is not in a stable release of Firefox for Android.
    • Update: fixed with https://bugzilla.mozilla.org/show_bug.cgi?id=1367494, so not a showstopper anymore.
  • 1360285: URL values not normalized to ASCII in WebExtensions API
    • I will add workaround code in uBO until issue is fixed.
    • Test page: uBO does not list all hostnames on that page without the workaround code.
    • Update: workaround code works just fine, not a blocking issue.
  • 1313401: Background Page LocalStorage is cleared along with site storage
    • This prevents uBO from remembering some UI preferences, but especially this breaks "Advanced settings".
    • Update: I do not consider this issue to be a showstopper for publishing webext-legacy on stable channel on August 22nd.
@uniquePWD
Copy link

https://bugzilla.mozilla.org/show_bug.cgi?id=945240 landed which apparently negates the need for https://bugzilla.mozilla.org/show_bug.cgi?id=1360285

@streetwolf
Copy link

@leplatrem
Copy link

Even if it's well documented in your wiki, I just opened 1386988: Confusing Legacy label for Embedded WebExtensions addons

@chetgurevitch
Copy link

1367494 is fixed for firefox 55.

@gorhill
Copy link
Owner Author

gorhill commented Aug 4, 2017

@leplatrem Not sure they can do anything about this. An embedded webext can be complete or partial.

uBO is a complete webext except for the data migration legacy code executed once at first install.

On the other hand I do know that ABP 2.9.1 is declaring hasEmbeddedWebExtension but the only webext API used is browser.storage.local, so it's still mostly a legacy extension

@lizzard
Copy link

lizzard commented Sep 6, 2017

We are seeing a very high volume crash on Firefox for Android 55, the current release, with the 1.14.4 version of uBlock: https://bugzilla.mozilla.org/show_bug.cgi?id=1347984#c30

@Luke-Baker
Copy link

1271354 is fixed in Firefox 56. Wiki - Firefox WebExtensions says it's the reason it's no longer possible to block requests from other extensions.

@gorhill
Copy link
Owner Author

gorhill commented Oct 10, 2017

Actually I will close this issue since uBO/webext version has been release since early September. Any remaining issues will be documented in the wiki.

@gorhill gorhill closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants