Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox keyboard shortcut for element picker no longer working (fixed in Firefox 66, FF bug #1303384) #2870

Closed
foss- opened this issue Aug 14, 2017 · 3 comments

Comments

@foss-
Copy link

foss- commented Aug 14, 2017

The keyboard shortcut which worked in previous uBlock Origin versions in Firefox is no longer working.
uBlock origin 1.13.9RC1
Firefox 56b2 or
Firefox 57 nightly
macOS 10.12.6

Keyboard shortcut setup for element picker
ublock origin shortcut

@gorhill
Copy link
Owner

gorhill commented Aug 14, 2017

The commands are declared in the manifest. The missing part is the browser missing the UI to assign shortcuts: https://bugzilla.mozilla.org/show_bug.cgi?id=1303384.

@foss-
Copy link
Author

foss- commented Aug 15, 2017

Thanks for the feedback. Does this mean, it is a regression in functionality due to missing APIs / functionality in firefox regarding web extensions? if so, this feels really wrong on mozillas part. force web ext move (which isn't such a bad idea) but then breaking stuff by not having APIs / required functionality ready for web exts?

firefox 1303384
firefox 1240350

@yourduskquibbles
Copy link

FYI for all it look it may now be possible to set extension shortcuts in Firefox v60 if I am reading this bugzilla discussion properly. There seems to be implementation documentation [1] [2] and example [3] as well.

[1] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/commands/update
[2] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/commands/reset
[3] https://github.com/mdn/webextensions-examples/tree/master/commands

@foss- foss- changed the title keyboard shortcut for element picker no longer working Firefox keyboard shortcut for element picker no longer working (fixed in Firefox 66, FF bug #1303384) Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants