Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Android (nightly 57) popup scrolling #3032

Closed
ojz0r opened this issue Sep 18, 2017 · 3 comments
Closed

Firefox Android (nightly 57) popup scrolling #3032

ojz0r opened this issue Sep 18, 2017 · 3 comments

Comments

@ojz0r
Copy link

ojz0r commented Sep 18, 2017

Describe the issue

I have previously reported (#2274) a bug that you fixed that the scrolling did not work in landscape for android. You fixed it quick last time but now it has returned when im testing the nightly builds.

Steps for anyone to reproduce the issue

Please see bug #2274.

Your settings

  • Browser/version: Firefox Android (nightly 57.0a1)
  • uBlock Origin version: 1.14.8
@gorhill
Copy link
Owner

gorhill commented Sep 18, 2017

Please report to Firefox devs. There has been no change in the popup panel code, and it still work fine in Fennec 55 and used to work fine in Nightly until recently, hence this means the issue is with Nightly. Using Chrome's mobile device debugger shows that there too uBO's popup panel works fine:

a

@gorhill gorhill closed this as completed Sep 18, 2017
@gorhill gorhill reopened this Sep 18, 2017
@gorhill
Copy link
Owner

gorhill commented Sep 18, 2017

Hmm, wait a bit, I just noticed that mobile=1 is not part of the URL. Investigating.

@gorhill
Copy link
Owner

gorhill commented Sep 18, 2017

Something changed in Nightly which seems to cause my browserAction.onClicked handler to no longer be called. That handler was opening the popup panel with the mobile=1 parameter, but now it seems Nightly is opening the panel itself, bypassing the handler.

@gorhill gorhill mentioned this issue Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants