Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlowMo UI #3038

Closed
publicarray opened this issue Sep 19, 2017 · 5 comments
Closed

SlowMo UI #3038

publicarray opened this issue Sep 19, 2017 · 5 comments

Comments

@publicarray
Copy link

Describe the issue

In FF Nightly and uBO 1.14.11b2 the Dynamic filtering panel opens in slow motion. (Is this a bug or a feature 😜 ) could also be a ff nightly bug

ublock

Your settings

Ticked "I am an advanced user", medium mode.

  • OS/version: macOS 10.12.6
  • Browser/version: Firefox Nightly - 57.0a1 (2017-09-19) (64-bit)
  • uBlock Origin version: 1.14.11b2
@gorhill
Copy link
Owner

gorhill commented Sep 19, 2017

I can't reproduce. Is this the webext version of uBO?

There was the fix to #3032, which was to add screen-size based heuristic to decide whether the popup panel must fill the whole viewport or not. Your screen size is obviously larger than the popup viewport. Did you toggle any setting in Firefox which could impede access to window.screen.availWidth or window.screen.availHeight?

@gorhill
Copy link
Owner

gorhill commented Sep 19, 2017

Ok, I can reproduce with privacy.resistFingerprinting set to true.

@publicarray
Copy link
Author

Ah yes I am using https://github.com/ghacksuserjs/ghacks-user.js which also sets these prefs:

/* 4501: enable privacy.resistFingerprinting (FF41+)
 * [1] https://bugzilla.mozilla.org/show_bug.cgi?id=418986 ***/
user_pref("privacy.resistFingerprinting", true); // (hidden pref) (not hidden FF55+)
/* 4502: set new window sizes to round to hundreds (FF55+) [SETUP]
 * [NOTE] Width will round down to multiples of 200s and height to 100s, to fit your screen.
 * The override values are a starting point to round from if you want some control
 * [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1330882
 * [2] https://hardware.metrics.mozilla.com/ ***/
user_pref("privacy.window.maxInnerWidth", 1600); // (hidden pref)
user_pref("privacy.window.maxInnerHeight", 900); // (hidden pref)

@gorhill
Copy link
Owner

gorhill commented Sep 19, 2017

All of these cascading issues is because browserAction.onClicked stopped being called on Firefox for Android -- no clue whether by design.

@publicarray
Copy link
Author

Thanks for the speedy fix 😄

gorhill added a commit that referenced this issue Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants