Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js error #819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix js error #819

wants to merge 1 commit into from

Conversation

cenkingunlugu
Copy link

Fix js error when there is no structuredText of startLine or structuredText of startLine has not text attribute.

Also fixes this issueon karma-coverage: karma-runner/karma-coverage#167

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.523% when pulling aeed316 on cenkingunlugu:master into bc84c31 on gotwarlost:master.

@cenkingunlugu cenkingunlugu mentioned this pull request Jun 22, 2017
@cenkingunlugu
Copy link
Author

Also solves: #817

Copy link

@FezVrasta FezVrasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this is just avoiding the error but not fixing the underlying problem

@glazar
Copy link

glazar commented Jun 29, 2017

I have a PR for only part of these changes. These should be linked.

@dmi3y
Copy link

dmi3y commented Aug 23, 2017

Does anyone figured why this happening? In my case, doing migration js>ts(x) and just started to seeing this error. Assuming some upstream is screwing the sourcemaps (webpack + babel (react) + typescript + karma)?

@mebibou
Copy link

mebibou commented Feb 18, 2018

@FezVrasta yes this is not a fix, it's just a "silent" fail. I think there should be an error thrown instead that just looks better than "TypeError", which would tell you that the coverage report cannot be mapped to the source file.
In my case, this happens because I am using TypeScript and so the coverage does not really cover the source file. I'm trying to switch and use karma-typescript with coverage to make it work but been quite unsuccessful so far

Copy link

@spencerdavis2000 spencerdavis2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works perfectly.
Can this get merged?

@fp-Kuba
Copy link

fp-Kuba commented Sep 5, 2018

+1 👍

fredknyazev pushed a commit to fredknyazev/istanbul that referenced this pull request Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants