Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NX_CONTAINER_SHORT_SHA_LENGTH documentation in container-metadata #1042

Open
monument-bmann opened this issue May 1, 2024 · 0 comments
Open

NX_CONTAINER_SHORT_SHA_LENGTH documentation in container-metadata #1042

monument-bmann opened this issue May 1, 2024 · 0 comments

Comments

@monument-bmann
Copy link

@jscutlery/semver generates a short git hash of 8 characters in length. Where @nx-tools/container-metadata default is 7.

I had to dig into the code to find this process.env.NX_CONTAINER_SHORT_SHA_LENGTH, to figure out where our deployment scripts were off.

Suggest this and any other env variables be documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monument-bmann