You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many tests take a list of texture formats. It would probably be good to consolidate those lists and or provide helpers/patterns for their usage.
For example. Some storage texture tests use TexelFormats in src/webgpu/shader/types.ts. Others use filter the list of all formats (kAllTextureFormats) by looking at kTextureFormatInfo[p.format].color?.storage === true or calling isTextureFormatUsableAsStorageFormat.
Ideally, a new texture format can be added to kTextureFormatInfo and would be picked up by all relevant tests? To do this, all tests should probably take some kind data from format_info.ts and call selectDeviceForTextureFormatOrSkipTestCase or other appropriate functions.
Many tests take a list of texture formats. It would probably be good to consolidate those lists and or provide helpers/patterns for their usage.
For example. Some storage texture tests use
TexelFormats
insrc/webgpu/shader/types.ts
. Others use filter the list of all formats (kAllTextureFormats
) by looking atkTextureFormatInfo[p.format].color?.storage === true
or callingisTextureFormatUsableAsStorageFormat
.Ideally, a new texture format can be added to
kTextureFormatInfo
and would be picked up by all relevant tests? To do this, all tests should probably take some kind data fromformat_info.ts
and callselectDeviceForTextureFormatOrSkipTestCase
or other appropriate functions.related: #3848
The text was updated successfully, but these errors were encountered: