Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate texture format lists for tests #3854

Open
greggman opened this issue Jul 11, 2024 · 0 comments
Open

Consolidate texture format lists for tests #3854

greggman opened this issue Jul 11, 2024 · 0 comments

Comments

@greggman
Copy link
Contributor

Many tests take a list of texture formats. It would probably be good to consolidate those lists and or provide helpers/patterns for their usage.

For example. Some storage texture tests use TexelFormats in src/webgpu/shader/types.ts. Others use filter the list of all formats (kAllTextureFormats) by looking at kTextureFormatInfo[p.format].color?.storage === true or calling isTextureFormatUsableAsStorageFormat.

Ideally, a new texture format can be added to kTextureFormatInfo and would be picked up by all relevant tests? To do this, all tests should probably take some kind data from format_info.ts and call selectDeviceForTextureFormatOrSkipTestCase or other appropriate functions.

related: #3848

@greggman greggman changed the title Consolidate texture format lists for test Consolidate texture format lists for tests Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant