Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for WGPU_ARRAY_SLICE_UNDEFINED and friends. #3926

Open
Kangz opened this issue Sep 2, 2024 · 2 comments
Open

Add tests for WGPU_ARRAY_SLICE_UNDEFINED and friends. #3926

Kangz opened this issue Sep 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Kangz
Copy link
Collaborator

Kangz commented Sep 2, 2024

I'm seeing this one test webgpu:api,validation,render_pass,render_pass_descriptor:color_attachments,depthSlice,definedness:dimension="2d" fail in dawn.node because the UNDEFINED values in webgpu.h is not handled, however dawn.node doesn't handle any of the UNDEFINED values, so the other tests should fail as well.

@Kangz Kangz added the enhancement New feature or request label Sep 2, 2024
@kainino0x
Copy link
Collaborator

We definitely test some of the dictionary members that are optional or have defaults. Is dawn.node handling some of the defaults in the generated code layer and missing others that need to be manually handled? Otherwise I'm surprised we haven't noticed problems eariler.

@Kangz
Copy link
Collaborator Author

Kangz commented Sep 4, 2024

This issue is that we should also test UINT32_MAX because it has a specific meaning in webgpu.h and could be forgotten in some implementations in their handling of mipLevelCount / arrayLayerCount etc. The depthSlice test correctly checks this but I believe that it is the only one (I just checked that dawn.node doesn't handle UINT32_MAX mipLevelCount/ArrayLayerCount).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants