Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for GPUShaderModuleDescriptor.compilationHints #3971

Open
ErichDonGubler opened this issue Sep 27, 2024 · 1 comment
Open

Add coverage for GPUShaderModuleDescriptor.compilationHints #3971

ErichDonGubler opened this issue Sep 27, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ErichDonGubler
Copy link
Member

ErichDonGubler commented Sep 27, 2024 •
edited
Loading

Things to cover:

  • Check that valid compilationHints are accepted:
  • Check that invalid compilationHints are also accepted; cases:
    • No matching entryPoint in the code provided in the module descriptor
    • Invalid layout provided
    • Mismatched layout provided
    • Invalid module (for a reasonable set of errors, not exhaustive?)
    • Combinations of the above?
@ErichDonGubler ErichDonGubler added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2024
@ErichDonGubler
Copy link
Member Author

I'm not sure what form this coverage would take, but I gave it my best shot in the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
CTS
Status: Open (no TODO)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErichDonGubler