Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readSinglePixelFrom2DTexture helper #1088

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 18, 2022

Since it reads only one pixel, this should use the new
getTextureSubCopyLayout instead of getTextureCopyLayout.

Tested in render_pass,resolve:render_pass_resolve tests.

Issue: another followup to #1068 and #1077


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Since it reads only one pixel, this should use the new
getTextureSubCopyLayout instead of getTextureCopyLayout.
@kainino0x kainino0x enabled auto-merge (squash) March 18, 2022 20:08
@github-actions
Copy link

Previews, as seen when this build job started (aa3b151):
Run tests | View tsdoc

@kainino0x kainino0x merged commit 6600201 into gpuweb:main Mar 18, 2022
@kainino0x kainino0x deleted the fix-render_pass_resolve branch March 18, 2022 20:23
kainino0x added a commit that referenced this pull request Mar 18, 2022
Since it reads only one pixel, this should use the new
getTextureSubCopyLayout instead of getTextureCopyLayout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants