Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'sampler,device_mismatch' test to createBindGroup.spec.ts #1867

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

Gyuyoung
Copy link
Collaborator

@Gyuyoung Gyuyoung commented Sep 27, 2022

This PR adds a new test to ensure that a validation error happens if createBindGroup is called with a sampler created from another device.

Issue: #884, #912


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This PR adds a new test to ensure that a validation error happens
if createBindGroup is called with a sampler created from another device.

Issue: 884, 912
@github-actions
Copy link

Previews, as seen when this build job started (2fb7dfc):
Run tests | View tsdoc

@Gyuyoung Gyuyoung marked this pull request as ready for review September 27, 2022 03:25
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kainino0x kainino0x enabled auto-merge (squash) September 28, 2022 02:29
@kainino0x kainino0x merged commit 2c53b58 into gpuweb:main Sep 28, 2022
@github-actions
Copy link

Previews, as seen when this build job started (50bbb8f):
Run tests | View tsdoc

@Gyuyoung Gyuyoung deleted the sampler-device-mismatch branch September 28, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants