Test usage field of GPUTextureViewDescriptor #3954
Conversation
Add variants of existing view format writing tests to cover end2end inherited and minimal view usage. Add validation tests for texture view creation with usage and texture view usage compatability in render passes/bind groups.
| @@ -280,6 +299,7 @@ Read values from color array in the shader, and write it to the texture view via | |||
| - x= every texture format | |||
| - x= sampleCount {1, 4} if valid | |||
| - x= every possible view write method (see above) | |||
| - x= inherited or minal texture view usage | |||
There was a problem hiding this comment.
| - x= inherited or minal texture view usage | |
| - x= inherited or minimal texture view usage |
| @@ -291,7 +311,8 @@ TODO: Test rgb10a2uint when TexelRepresentation.numericRange is made per-compone | |||
| .combine('method', kTextureViewWriteMethods) | |||
| .combine('format', kRegularTextureFormats) | |||
| .combine('sampleCount', [1, 4]) | |||
| .filter(({ format, method, sampleCount }) => { | |||
| .combine('viewUsageMethod', kTextureViewUsageMethods) | |||
There was a problem hiding this comment.
nit: move combine after filter, since the filter doesn't need this parameter. (it's a bit more efficient because the filter will have to run over fewer items)
| t.skipIfTextureFormatNotUsableAsStorageTexture(format); | ||
| } | ||
| if (textureUsage & GPUTextureUsage.RENDER_ATTACHMENT && info.color && !info.colorRender) { | ||
| t.skip(`Texture with ${format} is not usable as a render attachment`); |
There was a problem hiding this comment.
nit: These can be skipped at param building time (using filter) rather than here, which reduces the total number of tests.
(Someday the texture format info should depend on the device, but right now we only test base-level devices in most tests.)
| }); | ||
| renderPassEncoder.end(); | ||
|
|
||
| const success = viewUsage === 0 || viewUsage & GPUTextureUsage.RENDER_ATTACHMENT; |
There was a problem hiding this comment.
nit: success won't be a boolean, which is slightly weird. Either check the value directly
(viewUsage & GPUTextureUsage.RENDER_ATTACHMENT) !== 0
or cast to boolean
!!(viewUsage & GPUTextureUsage.RENDER_ATTACHMENT) or
Boolean(viewUsage & GPUTextureUsage.RENDER_ATTACHMENT)
| ) | ||
| .params(u => | ||
| u | ||
| .combine('usage', ['color-attachment', ...kTextureBindingTypes] as const) |
There was a problem hiding this comment.
nit: usage isn't a GPUTextureUsage, probably should be named something like bindingType
Add variants of existing view format writing tests to cover end2end inherited and minimal view usage.
Add validation tests for texture view creation with usage and texture view usage compatability in render passes/bind groups.
fixes: #3953
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.