Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation tests on the limit of max vertex output location with … #3958

Merged

Conversation

Jiawei-Shao
Copy link
Collaborator

@Jiawei-Shao Jiawei-Shao commented Sep 19, 2024

…clip_distances

This patch adds the validation tests on the limit of max vertex output location with clip_distances. According to the WebGPU SPEC, the maximum vertex output location will be decreased by (align(clipDistancesArraySize, 4) / 4) when clip_distances is used.

Fixed: #3773


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

…clip_distances

This patch adds the validation tests on the limit of max vertex output location with
clip_distances. According to the WebGPU SPEC, the maximum vertex output location will
be decreased by (align(clipDistancesArraySize, 4) / 4) when clip_distances is used.
Copy link
Contributor

@jzm-intel jzm-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@Jiawei-Shao Jiawei-Shao merged commit 9387aa0 into gpuweb:main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test clip-distances feature
3 participants