Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textureNumLayers view_type subcase #3963

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Sep 24, 2024

  • It seems that inside beforeAllSubcases subcases parameters are not present in t.params.
  • Somehow my default vscode typescript setup intellisense didn't report t.params.view is undefined (Because t.params.aaa inside beforeAllSubcases is JSONWithUndefined, Bug filed). npm run fix runs eslint. Shall we use typescript-eslint?

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@shrekshao shrekshao merged commit 2cce943 into gpuweb:main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants